Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove extra validation from builder response in builder proposal #6478

Merged
merged 3 commits into from
Feb 26, 2024
Merged

fix: remove extra validation from builder response in builder proposal #6478

merged 3 commits into from
Feb 26, 2024

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Feb 24, 2024

remove this extra check which might reduce some time to publish the builder block (although builder might have published but still)

@g11tech g11tech requested a review from a team as a code owner February 24, 2024 13:22
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2024 •
edited
Loading

Codecov Report

Merging #6478 (d38219b) into unstable (8943ab6) will not change coverage.
Report is 2 commits behind head on unstable.
The diff coverage is n/a.

❗ Current head d38219b differs from pull request most recent head ee71aa4. Consider uploading reports for the commit ee71aa4 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #6478   +/-   ##
=========================================
  Coverage     61.72%   61.72%           
=========================================
  Files           555      555           
  Lines         58204    58204           
  Branches       1839     1839           
=========================================
  Hits          35925    35925           
  Misses        22240    22240           
  Partials         39       39

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 24, 2024 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 03dfefd Previous: 06210ef Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 798.05 us/op 779.82 us/op 1.02
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 79.357 us/op 82.723 us/op 0.96
BLS verify - blst-native 1.2482 ms/op 1.3125 ms/op 0.95
BLS verifyMultipleSignatures 3 - blst-native 2.6224 ms/op 2.7442 ms/op 0.96
BLS verifyMultipleSignatures 8 - blst-native 5.9097 ms/op 5.9998 ms/op 0.98
BLS verifyMultipleSignatures 32 - blst-native 21.780 ms/op 21.972 ms/op 0.99
BLS verifyMultipleSignatures 64 - blst-native 42.465 ms/op 43.262 ms/op 0.98
BLS verifyMultipleSignatures 128 - blst-native 84.251 ms/op 85.955 ms/op 0.98
BLS deserializing 10000 signatures 899.53 ms/op 924.73 ms/op 0.97
BLS deserializing 100000 signatures 9.1777 s/op 9.1489 s/op 1.00
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3137 ms/op 1.3245 ms/op 0.99
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.4745 ms/op 1.5728 ms/op 0.94
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.2643 ms/op 3.0956 ms/op 0.73
BLS verifyMultipleSignatures - same message - 64 - blst-native 4.3868 ms/op 3.3373 ms/op 1.31
BLS verifyMultipleSignatures - same message - 128 - blst-native 7.2981 ms/op 7.7441 ms/op 0.94
BLS aggregatePubkeys 32 - blst-native 26.851 us/op 27.207 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 97.977 us/op 98.954 us/op 0.99
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 50.760 ms/op 54.270 ms/op 0.94
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 47.551 ms/op 47.616 ms/op 1.00
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 30.153 ms/op 31.114 ms/op 0.97
getSlashingsAndExits - default max 153.31 us/op 184.78 us/op 0.83
getSlashingsAndExits - 2k 318.78 us/op 412.48 us/op 0.77
proposeBlockBody type=full, size=empty 4.9971 ms/op 5.5092 ms/op 0.91
isKnown best case - 1 super set check 327.00 ns/op 309.00 ns/op 1.06
isKnown normal case - 2 super set checks 307.00 ns/op 293.00 ns/op 1.05
isKnown worse case - 16 super set checks 311.00 ns/op 286.00 ns/op 1.09
CheckpointStateCache - add get delete 5.2060 us/op 5.0780 us/op 1.03
validate api signedAggregateAndProof - struct 2.7078 ms/op 2.7450 ms/op 0.99
validate gossip signedAggregateAndProof - struct 2.7094 ms/op 2.7553 ms/op 0.98
validate gossip attestation - vc 640000 1.3415 ms/op 1.3457 ms/op 1.00
batch validate gossip attestation - vc 640000 - chunk 32 162.83 us/op 161.48 us/op 1.01
batch validate gossip attestation - vc 640000 - chunk 64 140.55 us/op 141.85 us/op 0.99
batch validate gossip attestation - vc 640000 - chunk 128 135.90 us/op 136.70 us/op 0.99
batch validate gossip attestation - vc 640000 - chunk 256 132.02 us/op 128.27 us/op 1.03
pickEth1Vote - no votes 1.2662 ms/op 1.2445 ms/op 1.02
pickEth1Vote - max votes 10.218 ms/op 12.908 ms/op 0.79
pickEth1Vote - Eth1Data hashTreeRoot value x2048 17.805 ms/op 19.223 ms/op 0.93
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 25.579 ms/op 34.142 ms/op 0.75
pickEth1Vote - Eth1Data fastSerialize value x2048 587.24 us/op 644.37 us/op 0.91
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.6485 ms/op 8.0954 ms/op 0.70
bytes32 toHexString 469.00 ns/op 489.00 ns/op 0.96
bytes32 Buffer.toString(hex) 275.00 ns/op 286.00 ns/op 0.96
bytes32 Buffer.toString(hex) from Uint8Array 392.00 ns/op 434.00 ns/op 0.90
bytes32 Buffer.toString(hex) + 0x 276.00 ns/op 290.00 ns/op 0.95
Object access 1 prop 0.15000 ns/op 0.15600 ns/op 0.96
Map access 1 prop 0.14400 ns/op 0.14000 ns/op 1.03
Object get x1000 7.2090 ns/op 7.2800 ns/op 0.99
Map get x1000 0.73100 ns/op 0.72800 ns/op 1.00
Object set x1000 47.594 ns/op 49.176 ns/op 0.97
Map set x1000 37.634 ns/op 38.138 ns/op 0.99
Return object 10000 times 0.22480 ns/op 0.23230 ns/op 0.97
Throw Error 10000 times 3.6773 us/op 3.8239 us/op 0.96
fastMsgIdFn sha256 / 200 bytes 3.0720 us/op 3.2100 us/op 0.96
fastMsgIdFn h32 xxhash / 200 bytes 250.00 ns/op 275.00 ns/op 0.91
fastMsgIdFn h64 xxhash / 200 bytes 327.00 ns/op 341.00 ns/op 0.96
fastMsgIdFn sha256 / 1000 bytes 11.018 us/op 11.239 us/op 0.98
fastMsgIdFn h32 xxhash / 1000 bytes 371.00 ns/op 398.00 ns/op 0.93
fastMsgIdFn h64 xxhash / 1000 bytes 389.00 ns/op 410.00 ns/op 0.95
fastMsgIdFn sha256 / 10000 bytes 101.13 us/op 102.00 us/op 0.99
fastMsgIdFn h32 xxhash / 10000 bytes 1.8080 us/op 1.8620 us/op 0.97
fastMsgIdFn h64 xxhash / 10000 bytes 1.2510 us/op 1.2700 us/op 0.99
send data - 1000 256B messages 16.678 ms/op 18.696 ms/op 0.89
send data - 1000 512B messages 24.901 ms/op 25.261 ms/op 0.99
send data - 1000 1024B messages 38.354 ms/op 38.805 ms/op 0.99
send data - 1000 1200B messages 34.443 ms/op 37.951 ms/op 0.91
send data - 1000 2048B messages 47.826 ms/op 49.974 ms/op 0.96
send data - 1000 4096B messages 42.201 ms/op 44.063 ms/op 0.96
send data - 1000 16384B messages 115.51 ms/op 114.98 ms/op 1.00
send data - 1000 65536B messages 435.54 ms/op 458.93 ms/op 0.95
enrSubnets - fastDeserialize 64 bits 1.1640 us/op 1.2140 us/op 0.96
enrSubnets - ssz BitVector 64 bits 401.00 ns/op 416.00 ns/op 0.96
enrSubnets - fastDeserialize 4 bits 161.00 ns/op 166.00 ns/op 0.97
enrSubnets - ssz BitVector 4 bits 407.00 ns/op 420.00 ns/op 0.97
prioritizePeers score -10:0 att 32-0.1 sync 2-0 97.627 us/op 106.36 us/op 0.92
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 128.29 us/op 134.56 us/op 0.95
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 170.09 us/op 160.40 us/op 1.06
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 286.09 us/op 282.06 us/op 1.01
prioritizePeers score 0:0 att 64-1 sync 4-1 339.43 us/op 328.89 us/op 1.03
array of 16000 items push then shift 1.6069 us/op 1.6076 us/op 1.00
LinkedList of 16000 items push then shift 8.8700 ns/op 8.8080 ns/op 1.01
array of 16000 items push then pop 108.64 ns/op 74.941 ns/op 1.45
LinkedList of 16000 items push then pop 8.8400 ns/op 8.5720 ns/op 1.03
array of 24000 items push then shift 2.5850 us/op 2.3316 us/op 1.11
LinkedList of 24000 items push then shift 8.9050 ns/op 8.7270 ns/op 1.02
array of 24000 items push then pop 127.93 ns/op 95.937 ns/op 1.33
LinkedList of 24000 items push then pop 8.6140 ns/op 9.0750 ns/op 0.95
intersect bitArray bitLen 8 5.7780 ns/op 5.6380 ns/op 1.02
intersect array and set length 8 63.671 ns/op 60.551 ns/op 1.05
intersect bitArray bitLen 128 35.455 ns/op 34.398 ns/op 1.03
intersect array and set length 128 852.49 ns/op 836.29 ns/op 1.02
bitArray.getTrueBitIndexes() bitLen 128 1.4320 us/op 1.4080 us/op 1.02
bitArray.getTrueBitIndexes() bitLen 248 2.4390 us/op 2.3200 us/op 1.05
bitArray.getTrueBitIndexes() bitLen 512 4.8800 us/op 4.5950 us/op 1.06
Buffer.concat 32 items 1.0180 us/op 966.00 ns/op 1.05
Uint8Array.set 32 items 2.2130 us/op 2.3780 us/op 0.93
Set add up to 64 items then delete first 4.3662 us/op 4.2837 us/op 1.02
OrderedSet add up to 64 items then delete first 5.5028 us/op 5.3690 us/op 1.02
Set add up to 64 items then delete last 4.5632 us/op 4.5455 us/op 1.00
OrderedSet add up to 64 items then delete last 5.7076 us/op 5.6686 us/op 1.01
Set add up to 64 items then delete middle 4.5532 us/op 4.5185 us/op 1.01
OrderedSet add up to 64 items then delete middle 7.0031 us/op 6.9274 us/op 1.01
Set add up to 128 items then delete first 9.3358 us/op 9.2168 us/op 1.01
OrderedSet add up to 128 items then delete first 12.357 us/op 12.113 us/op 1.02
Set add up to 128 items then delete last 9.2083 us/op 9.0880 us/op 1.01
OrderedSet add up to 128 items then delete last 11.646 us/op 11.453 us/op 1.02
Set add up to 128 items then delete middle 9.0834 us/op 9.0351 us/op 1.01
OrderedSet add up to 128 items then delete middle 16.879 us/op 16.710 us/op 1.01
Set add up to 256 items then delete first 18.640 us/op 18.714 us/op 1.00
OrderedSet add up to 256 items then delete first 24.994 us/op 25.072 us/op 1.00
Set add up to 256 items then delete last 18.111 us/op 18.068 us/op 1.00
OrderedSet add up to 256 items then delete last 23.133 us/op 23.287 us/op 0.99
Set add up to 256 items then delete middle 18.197 us/op 18.010 us/op 1.01
OrderedSet add up to 256 items then delete middle 45.870 us/op 44.905 us/op 1.02
transfer serialized Status (84 B) 1.7530 us/op 1.6730 us/op 1.05
copy serialized Status (84 B) 1.3190 us/op 1.2470 us/op 1.06
transfer serialized SignedVoluntaryExit (112 B) 1.9030 us/op 1.7370 us/op 1.10
copy serialized SignedVoluntaryExit (112 B) 1.4500 us/op 1.3710 us/op 1.06
transfer serialized ProposerSlashing (416 B) 2.9620 us/op 2.9400 us/op 1.01
copy serialized ProposerSlashing (416 B) 2.7530 us/op 2.8300 us/op 0.97
transfer serialized Attestation (485 B) 3.1010 us/op 3.1240 us/op 0.99
copy serialized Attestation (485 B) 2.4380 us/op 2.7590 us/op 0.88
transfer serialized AttesterSlashing (33232 B) 2.9280 us/op 3.1790 us/op 0.92
copy serialized AttesterSlashing (33232 B) 6.7140 us/op 6.5230 us/op 1.03
transfer serialized Small SignedBeaconBlock (128000 B) 2.9260 us/op 3.3260 us/op 0.88
copy serialized Small SignedBeaconBlock (128000 B) 14.746 us/op 15.401 us/op 0.96
transfer serialized Avg SignedBeaconBlock (200000 B) 3.1510 us/op 3.4210 us/op 0.92
copy serialized Avg SignedBeaconBlock (200000 B) 21.581 us/op 21.167 us/op 1.02
transfer serialized BlobsSidecar (524380 B) 3.1690 us/op 2.7610 us/op 1.15
copy serialized BlobsSidecar (524380 B) 87.697 us/op 135.02 us/op 0.65
transfer serialized Big SignedBeaconBlock (1000000 B) 3.3230 us/op 2.7160 us/op 1.22
copy serialized Big SignedBeaconBlock (1000000 B) 153.36 us/op 157.62 us/op 0.97
pass gossip attestations to forkchoice per slot 4.2640 ms/op 3.9606 ms/op 1.08
forkChoice updateHead vc 100000 bc 64 eq 0 684.11 us/op 749.83 us/op 0.91
forkChoice updateHead vc 600000 bc 64 eq 0 4.8436 ms/op 4.3707 ms/op 1.11
forkChoice updateHead vc 1000000 bc 64 eq 0 6.9665 ms/op 6.9296 ms/op 1.01
forkChoice updateHead vc 600000 bc 320 eq 0 4.1508 ms/op 4.1864 ms/op 0.99
forkChoice updateHead vc 600000 bc 1200 eq 0 4.2335 ms/op 4.2759 ms/op 0.99
forkChoice updateHead vc 600000 bc 7200 eq 0 5.2231 ms/op 5.0943 ms/op 1.03
forkChoice updateHead vc 600000 bc 64 eq 1000 11.013 ms/op 11.039 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 10000 11.836 ms/op 11.849 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 300000 15.604 ms/op 14.796 ms/op 1.05
computeDeltas 500000 validators 300 proto nodes 6.4835 ms/op 6.5931 ms/op 0.98
computeDeltas 500000 validators 1200 proto nodes 6.3003 ms/op 6.4404 ms/op 0.98
computeDeltas 500000 validators 7200 proto nodes 6.4073 ms/op 6.2840 ms/op 1.02
computeDeltas 750000 validators 300 proto nodes 9.7356 ms/op 9.5380 ms/op 1.02
computeDeltas 750000 validators 1200 proto nodes 9.4856 ms/op 9.3586 ms/op 1.01
computeDeltas 750000 validators 7200 proto nodes 9.3756 ms/op 9.3294 ms/op 1.00
computeDeltas 1400000 validators 300 proto nodes 18.431 ms/op 18.924 ms/op 0.97
computeDeltas 1400000 validators 1200 proto nodes 18.820 ms/op 18.782 ms/op 1.00
computeDeltas 1400000 validators 7200 proto nodes 18.274 ms/op 18.676 ms/op 0.98
computeDeltas 2100000 validators 300 proto nodes 28.403 ms/op 27.526 ms/op 1.03
computeDeltas 2100000 validators 1200 proto nodes 27.212 ms/op 28.483 ms/op 0.96
computeDeltas 2100000 validators 7200 proto nodes 28.564 ms/op 28.026 ms/op 1.02
altair processAttestation - 250000 vs - 7PWei normalcase 2.0935 ms/op 2.2239 ms/op 0.94
altair processAttestation - 250000 vs - 7PWei worstcase 3.1362 ms/op 3.1260 ms/op 1.00
altair processAttestation - setStatus - 1/6 committees join 181.17 us/op 141.93 us/op 1.28
altair processAttestation - setStatus - 1/3 committees join 351.70 us/op 280.34 us/op 1.25
altair processAttestation - setStatus - 1/2 committees join 477.39 us/op 377.75 us/op 1.26
altair processAttestation - setStatus - 2/3 committees join 602.77 us/op 480.52 us/op 1.25
altair processAttestation - setStatus - 4/5 committees join 802.21 us/op 647.81 us/op 1.24
altair processAttestation - setStatus - 100% committees join 917.84 us/op 831.35 us/op 1.10
altair processBlock - 250000 vs - 7PWei normalcase 11.050 ms/op 10.274 ms/op 1.08
altair processBlock - 250000 vs - 7PWei normalcase hashState 33.504 ms/op 35.332 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase 38.304 ms/op 39.422 ms/op 0.97
altair processBlock - 250000 vs - 7PWei worstcase hashState 88.832 ms/op 101.29 ms/op 0.88
phase0 processBlock - 250000 vs - 7PWei normalcase 2.9540 ms/op 3.1325 ms/op 0.94
phase0 processBlock - 250000 vs - 7PWei worstcase 29.594 ms/op 29.285 ms/op 1.01
altair processEth1Data - 250000 vs - 7PWei normalcase 637.20 us/op 595.83 us/op 1.07
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 8.4620 us/op 11.161 us/op 0.76
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 70.789 us/op 100.31 us/op 0.71
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 20.787 us/op 18.291 us/op 1.14
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 10.909 us/op 15.313 us/op 0.71
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 163.47 us/op 230.72 us/op 0.71
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.6009 ms/op 1.0214 ms/op 1.57
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.9819 ms/op 2.9081 ms/op 0.68
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.5911 ms/op 3.3469 ms/op 0.48
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.6469 ms/op 3.5664 ms/op 1.02
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.6222 ms/op 2.1402 ms/op 1.23
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.8455 ms/op 4.3858 ms/op 1.10
Tree 40 250000 create 386.80 ms/op 343.04 ms/op 1.13
Tree 40 250000 get(125000) 205.71 ns/op 187.45 ns/op 1.10
Tree 40 250000 set(125000) 1.0218 us/op 941.30 ns/op 1.09
Tree 40 250000 toArray() 21.384 ms/op 18.046 ms/op 1.19
Tree 40 250000 iterate all - toArray() + loop 21.785 ms/op 18.520 ms/op 1.18
Tree 40 250000 iterate all - get(i) 71.153 ms/op 64.527 ms/op 1.10
MutableVector 250000 create 11.967 ms/op 21.964 ms/op 0.54
MutableVector 250000 get(125000) 6.4640 ns/op 6.6400 ns/op 0.97
MutableVector 250000 set(125000) 286.02 ns/op 256.10 ns/op 1.12
MutableVector 250000 toArray() 3.0568 ms/op 3.4613 ms/op 0.88
MutableVector 250000 iterate all - toArray() + loop 4.0669 ms/op 3.4621 ms/op 1.17
MutableVector 250000 iterate all - get(i) 1.5149 ms/op 1.4924 ms/op 1.02
Array 250000 create 3.2797 ms/op 3.0724 ms/op 1.07
Array 250000 clone - spread 1.2660 ms/op 1.2605 ms/op 1.00
Array 250000 get(125000) 1.0320 ns/op 1.0360 ns/op 1.00
Array 250000 set(125000) 4.2200 ns/op 4.1220 ns/op 1.02
Array 250000 iterate all - loop 161.82 us/op 166.10 us/op 0.97
effectiveBalanceIncrements clone Uint8Array 300000 27.291 us/op 26.719 us/op 1.02
effectiveBalanceIncrements clone MutableVector 300000 336.00 ns/op 360.00 ns/op 0.93
effectiveBalanceIncrements rw all Uint8Array 300000 198.02 us/op 199.51 us/op 0.99
effectiveBalanceIncrements rw all MutableVector 300000 82.545 ms/op 82.501 ms/op 1.00
phase0 afterProcessEpoch - 250000 vs - 7PWei 113.98 ms/op 112.14 ms/op 1.02
phase0 beforeProcessEpoch - 250000 vs - 7PWei 53.612 ms/op 56.127 ms/op 0.96
altair processEpoch - mainnet_e81889 503.11 ms/op 560.24 ms/op 0.90
mainnet_e81889 - altair beforeProcessEpoch 82.549 ms/op 86.875 ms/op 0.95
mainnet_e81889 - altair processJustificationAndFinalization 15.088 us/op 23.351 us/op 0.65
mainnet_e81889 - altair processInactivityUpdates 6.3739 ms/op 5.6799 ms/op 1.12
mainnet_e81889 - altair processRewardsAndPenalties 42.806 ms/op 68.164 ms/op 0.63
mainnet_e81889 - altair processRegistryUpdates 2.6520 us/op 3.6860 us/op 0.72
mainnet_e81889 - altair processSlashings 443.00 ns/op 855.00 ns/op 0.52
mainnet_e81889 - altair processEth1DataReset 657.00 ns/op 841.00 ns/op 0.78
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.4220 ms/op 2.6589 ms/op 0.53
mainnet_e81889 - altair processSlashingsReset 3.4700 us/op 5.0280 us/op 0.69
mainnet_e81889 - altair processRandaoMixesReset 4.8520 us/op 6.4240 us/op 0.76
mainnet_e81889 - altair processHistoricalRootsUpdate 706.00 ns/op 1.0630 us/op 0.66
mainnet_e81889 - altair processParticipationFlagUpdates 3.3930 us/op 2.1600 us/op 1.57
mainnet_e81889 - altair processSyncCommitteeUpdates 788.00 ns/op 867.00 ns/op 0.91
mainnet_e81889 - altair afterProcessEpoch 117.40 ms/op 115.37 ms/op 1.02
capella processEpoch - mainnet_e217614 2.0568 s/op 2.3008 s/op 0.89
mainnet_e217614 - capella beforeProcessEpoch 468.06 ms/op 498.06 ms/op 0.94
mainnet_e217614 - capella processJustificationAndFinalization 13.461 us/op 21.900 us/op 0.61
mainnet_e217614 - capella processInactivityUpdates 20.222 ms/op 19.787 ms/op 1.02
mainnet_e217614 - capella processRewardsAndPenalties 429.20 ms/op 451.51 ms/op 0.95
mainnet_e217614 - capella processRegistryUpdates 20.127 us/op 26.599 us/op 0.76
mainnet_e217614 - capella processSlashings 476.00 ns/op 1.0290 us/op 0.46
mainnet_e217614 - capella processEth1DataReset 511.00 ns/op 934.00 ns/op 0.55
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.9660 ms/op 4.3050 ms/op 1.15
mainnet_e217614 - capella processSlashingsReset 2.9320 us/op 5.0090 us/op 0.59
mainnet_e217614 - capella processRandaoMixesReset 6.3890 us/op 7.3290 us/op 0.87
mainnet_e217614 - capella processHistoricalRootsUpdate 508.00 ns/op 1000.0 ns/op 0.51
mainnet_e217614 - capella processParticipationFlagUpdates 2.0390 us/op 2.1840 us/op 0.93
mainnet_e217614 - capella afterProcessEpoch 300.97 ms/op 335.77 ms/op 0.90
phase0 processEpoch - mainnet_e58758 426.65 ms/op 539.89 ms/op 0.79
mainnet_e58758 - phase0 beforeProcessEpoch 135.29 ms/op 169.28 ms/op 0.80
mainnet_e58758 - phase0 processJustificationAndFinalization 15.836 us/op 24.190 us/op 0.65
mainnet_e58758 - phase0 processRewardsAndPenalties 56.969 ms/op 60.941 ms/op 0.93
mainnet_e58758 - phase0 processRegistryUpdates 10.978 us/op 17.171 us/op 0.64
mainnet_e58758 - phase0 processSlashings 498.00 ns/op 1.0210 us/op 0.49
mainnet_e58758 - phase0 processEth1DataReset 450.00 ns/op 701.00 ns/op 0.64
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1959 ms/op 2.1668 ms/op 0.55
mainnet_e58758 - phase0 processSlashingsReset 4.1560 us/op 4.5090 us/op 0.92
mainnet_e58758 - phase0 processRandaoMixesReset 5.9420 us/op 6.1960 us/op 0.96
mainnet_e58758 - phase0 processHistoricalRootsUpdate 715.00 ns/op 800.00 ns/op 0.89
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.0090 us/op 5.2160 us/op 0.77
mainnet_e58758 - phase0 afterProcessEpoch 98.930 ms/op 95.289 ms/op 1.04
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3838 ms/op 1.3036 ms/op 1.06
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4859 ms/op 2.2100 ms/op 0.67
altair processInactivityUpdates - 250000 normalcase 23.499 ms/op 28.160 ms/op 0.83
altair processInactivityUpdates - 250000 worstcase 28.216 ms/op 40.044 ms/op 0.70
phase0 processRegistryUpdates - 250000 normalcase 11.148 us/op 14.488 us/op 0.77
phase0 processRegistryUpdates - 250000 badcase_full_deposits 440.20 us/op 744.88 us/op 0.59
phase0 processRegistryUpdates - 250000 worstcase 0.5 141.51 ms/op 138.09 ms/op 1.02
altair processRewardsAndPenalties - 250000 normalcase 59.042 ms/op 71.229 ms/op 0.83
altair processRewardsAndPenalties - 250000 worstcase 57.921 ms/op 70.866 ms/op 0.82
phase0 getAttestationDeltas - 250000 normalcase 9.0333 ms/op 8.6608 ms/op 1.04
phase0 getAttestationDeltas - 250000 worstcase 9.4109 ms/op 9.0328 ms/op 1.04
phase0 processSlashings - 250000 worstcase 88.474 us/op 133.06 us/op 0.66
altair processSyncCommitteeUpdates - 250000 155.33 ms/op 153.92 ms/op 1.01
BeaconState.hashTreeRoot - No change 358.00 ns/op 388.00 ns/op 0.92
BeaconState.hashTreeRoot - 1 full validator 154.34 us/op 189.35 us/op 0.82
BeaconState.hashTreeRoot - 32 full validator 1.6118 ms/op 1.7740 ms/op 0.91
BeaconState.hashTreeRoot - 512 full validator 12.198 ms/op 16.833 ms/op 0.72
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 132.08 us/op 222.85 us/op 0.59
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.8070 ms/op 2.6356 ms/op 0.69
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 24.221 ms/op 34.153 ms/op 0.71
BeaconState.hashTreeRoot - 1 balances 108.29 us/op 145.89 us/op 0.74
BeaconState.hashTreeRoot - 32 balances 984.84 us/op 1.3632 ms/op 0.72
BeaconState.hashTreeRoot - 512 balances 10.081 ms/op 11.299 ms/op 0.89
BeaconState.hashTreeRoot - 250000 balances 193.73 ms/op 248.85 ms/op 0.78
aggregationBits - 2048 els - zipIndexesInBitList 19.964 us/op 16.748 us/op 1.19
byteArrayEquals 32 75.797 ns/op 75.573 ns/op 1.00
Buffer.compare 32 55.817 ns/op 54.518 ns/op 1.02
byteArrayEquals 1024 2.0445 us/op 1.9977 us/op 1.02
Buffer.compare 1024 69.683 ns/op 69.775 ns/op 1.00
byteArrayEquals 16384 32.610 us/op 31.808 us/op 1.03
Buffer.compare 16384 278.80 ns/op 264.66 ns/op 1.05
byteArrayEquals 123687377 257.94 ms/op 246.98 ms/op 1.04
Buffer.compare 123687377 10.198 ms/op 6.3600 ms/op 1.60
byteArrayEquals 32 - diff last byte 83.395 ns/op 71.664 ns/op 1.16
Buffer.compare 32 - diff last byte 58.813 ns/op 55.946 ns/op 1.05
byteArrayEquals 1024 - diff last byte 2.1681 us/op 2.0337 us/op 1.07
Buffer.compare 1024 - diff last byte 75.346 ns/op 72.343 ns/op 1.04
byteArrayEquals 16384 - diff last byte 34.024 us/op 32.559 us/op 1.04
Buffer.compare 16384 - diff last byte 259.44 ns/op 275.96 ns/op 0.94
byteArrayEquals 123687377 - diff last byte 259.59 ms/op 245.67 ms/op 1.06
Buffer.compare 123687377 - diff last byte 10.901 ms/op 6.2096 ms/op 1.76
byteArrayEquals 32 - random bytes 6.6090 ns/op 5.3800 ns/op 1.23
Buffer.compare 32 - random bytes 62.743 ns/op 61.073 ns/op 1.03
byteArrayEquals 1024 - random bytes 6.6020 ns/op 5.1840 ns/op 1.27
Buffer.compare 1024 - random bytes 61.981 ns/op 60.163 ns/op 1.03
byteArrayEquals 16384 - random bytes 6.6160 ns/op 5.1830 ns/op 1.28
Buffer.compare 16384 - random bytes 61.883 ns/op 60.018 ns/op 1.03
byteArrayEquals 123687377 - random bytes 15.310 ns/op 8.2900 ns/op 1.85
Buffer.compare 123687377 - random bytes 77.630 ns/op 63.400 ns/op 1.22
regular array get 100000 times 45.968 us/op 44.890 us/op 1.02
wrappedArray get 100000 times 46.212 us/op 45.168 us/op 1.02
arrayWithProxy get 100000 times 15.571 ms/op 14.116 ms/op 1.10
ssz.Root.equals 56.492 ns/op 54.020 ns/op 1.05
byteArrayEquals 55.825 ns/op 53.714 ns/op 1.04
Buffer.compare 12.866 ns/op 10.865 ns/op 1.18
shuffle list - 16384 els 7.1358 ms/op 7.0101 ms/op 1.02
shuffle list - 250000 els 106.20 ms/op 104.31 ms/op 1.02
processSlot - 1 slots 21.389 us/op 17.301 us/op 1.24
processSlot - 32 slots 4.7265 ms/op 3.7481 ms/op 1.26
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 62.320 ms/op 68.848 ms/op 0.91
getCommitteeAssignments - req 1 vs - 250000 vc 2.5974 ms/op 2.4826 ms/op 1.05
getCommitteeAssignments - req 100 vs - 250000 vc 3.7765 ms/op 3.6671 ms/op 1.03
getCommitteeAssignments - req 1000 vs - 250000 vc 4.1911 ms/op 4.0524 ms/op 1.03
findModifiedValidators - 10000 modified validators 625.68 ms/op 543.60 ms/op 1.15
findModifiedValidators - 1000 modified validators 476.49 ms/op 423.42 ms/op 1.13
findModifiedValidators - 100 modified validators 446.52 ms/op 418.97 ms/op 1.07
findModifiedValidators - 10 modified validators 420.30 ms/op 400.64 ms/op 1.05
findModifiedValidators - 1 modified validators 430.88 ms/op 402.43 ms/op 1.07
findModifiedValidators - no difference 454.60 ms/op 383.21 ms/op 1.19
compare ViewDUs 5.0272 s/op 4.9357 s/op 1.02
compare each validator Uint8Array 1.5595 s/op 2.0517 s/op 0.76
compare ViewDU to Uint8Array 1.3354 s/op 1.1707 s/op 1.14
migrate state 1000000 validators, 24 modified, 0 new 761.46 ms/op 882.49 ms/op 0.86
migrate state 1000000 validators, 1700 modified, 1000 new 1.0088 s/op 1.2152 s/op 0.83
migrate state 1000000 validators, 3400 modified, 2000 new 1.2615 s/op 1.4859 s/op 0.85
migrate state 1500000 validators, 24 modified, 0 new 761.23 ms/op 898.24 ms/op 0.85
migrate state 1500000 validators, 1700 modified, 1000 new 1.1833 s/op 1.2102 s/op 0.98
migrate state 1500000 validators, 3400 modified, 2000 new 1.8518 s/op 1.4668 s/op 1.26
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 6.5600 ns/op 4.2800 ns/op 1.53
state getBlockRootAtSlot - 250000 vs - 7PWei 845.25 ns/op 953.51 ns/op 0.89
computeProposers - vc 250000 11.688 ms/op 8.4933 ms/op 1.38
computeEpochShuffling - vc 250000 129.53 ms/op 100.57 ms/op 1.29
getNextSyncCommittee - vc 250000 192.45 ms/op 147.05 ms/op 1.31
computeSigningRoot for AttestationData 29.907 us/op 27.063 us/op 1.11
hash AttestationData serialized data then Buffer.toString(base64) 2.4132 us/op 2.2508 us/op 1.07
toHexString serialized data 1.0902 us/op 1.0409 us/op 1.05
Buffer.toString(base64) 230.57 ns/op 226.48 ns/op 1.02

by benchmarkbot/action

@g11tech g11tech changed the title remove extra validation from builder response in builder proposal fix: remove extra validation from builder response in builder proposal Feb 24, 2024
twoeths
twoeths previously approved these changes Feb 26, 2024
View reviewed changes
@g11tech g11tech enabled auto-merge (squash) February 26, 2024 06:52
twoeths
twoeths previously approved these changes Feb 26, 2024
View reviewed changes
@g11tech g11tech merged commit 2bb4ae6 into unstable Feb 26, 2024
19 of 20 checks passed
@g11tech g11tech deleted the remove-builderres-check branch February 26, 2024 07:50
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.17.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoeths twoeths twoeths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g11tech @wemeetagain @twoeths